style: use dollar variables (getting links) #1844
Conversation
|
Preview for this PR was built for commit |
honzajavorek
added
the
t-academy
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const data = []; | ||
| $(".product-item").each((i, element) => { | ||
| const productItem = $(element); | ||
| const $items = $(".product-item").map((i, element) => { |
There was a problem hiding this comment.
| const $items = $(".product-item").map((i, element) => { | |
| const data = $(".product-item").toArray().map((element) => { |
Adding the toArray instruction, you have a "regular" map method, that returns regular objects instead of Cheerio objects (less confusing), and you can remove the const data = $items.get(); later. Moreover, the i index was unused.
| }); | ||
| const data = $items.get(); |
There was a problem hiding this comment.
| const data = $items.get(); |
| const productItem = $(element); | ||
| const item = parseProduct(productItem); | ||
| data.push(item); | ||
| const $items = $(".product-item").map((i, element) => { |
There was a problem hiding this comment.
| const $items = $(".product-item").map((i, element) => { | |
| const data = $(".product-item").toArray().map((element) => { |
| }); | ||
| const data = $items.get(); |
There was a problem hiding this comment.
| const data = $items.get(); |
| const data = [] | ||
| $(".product-item").each((i, element) => { | ||
| const productItem = $(element); | ||
| const $items = $(".product-item").map((i, element) => { |
There was a problem hiding this comment.
| const $items = $(".product-item").map((i, element) => { | |
| const data = $(".product-item").toArray().map((element) => { |
| }); | ||
| const data = $items.get(); |
There was a problem hiding this comment.
| const data = $items.get(); |
|
@gullmar Thank you! 🙇♂️ As I mentioned in the PR description, these changes still use |
|
I'm sorry, because it's a bit confusing and it's easy to overlook the note I made 🫠 |
As I progressed with apify#1584 I felt the code examples were starting to be more and more complex. Then I remembered that when I was young, us jQuery folks used to lean towards a naming convention where variables holding jQuery selections were prefixed with $. I changed the code examples in all lessons to adhere to this as I feel it makes them more readable and less cluttered. ----- ℹ️ The changes still use `$.map` and `$.each`, because they were made prior to the facb3c0 commit. It's gonna happen, but not yet.
As I progressed with #1584 I felt the code examples were starting to be more and more complex. Then I remembered that when I was young, us jQuery folks used to lean towards a naming convention where variables holding jQuery selections were prefixed with $. I changed the code examples in all lessons to adhere to this as I feel it makes them more readable and less cluttered.
ℹ️ The changes still use
$.mapand$.each, because they were made prior to the facb3c0 commit. It's gonna happen, but not yet.